7.1 Fix UI glitches #2704
Merged
7.1 Fix UI glitches #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
approved these changes
Jan 24, 2024
We want to show that a page is online in page edit mode. It would be confusing otherwise.
We reduce the many times we update the visible and delegate it to the view where it gets hidden, if the upload is successful. Fixes a bug where the upload is still visible on the page edit screen with upload happening in the assign image dialog.
tvdeyen
force-pushed
the
hide-elemen-errors-on-save
branch
from
50dbbb3 to
cee4f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist