Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActionNotFound in PictureController #2714

Merged

Conversation

kulturbande
Copy link
Contributor

What is this pull request for?

The default setting of Rails 7.1 will raise an exception if a callback action was not found. The info - method is not available in picture controller and will lead to an exception if the option is turned on in Rails 7.1.

Screenshots

CleanShot 2024-02-03 at 15 16 55@2x

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

The default setting of Rails 7.1 will raise an exception if a callback action was not found. The info - method is not available in picture controller and will lead to an exception if the option is turned on in Rails 7.1.
@tvdeyen
Copy link
Member

tvdeyen commented Feb 5, 2024

@kulturbande maybe it makes sense to conditionally enable this in our dummy app development and test envs?

@tvdeyen tvdeyen added the backport-to-7.1-stable Needs to be backported to 7.1-stable label Feb 5, 2024
@tvdeyen tvdeyen merged commit 9efa7cc into AlchemyCMS:main Feb 5, 2024
35 checks passed
@alchemycms-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
7.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tvdeyen added a commit that referenced this pull request Feb 5, 2024
[7.1-stable] Merge pull request #2714 from kulturbande/fix-rails-7.1-picture-controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.1-stable Needs to be backported to 7.1-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants