Fix module error #2820
Merged
Fix module error #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message in Alchemy::Modules.validate_controllers_existence relies on the definition_hash variable to be present. Because it isn't, we get a NameError rather than the expected RuntimeError.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2820 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 225 225
Lines 6129 6129
=======================================
Hits 5879 5879
Misses 250 250 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Apr 4, 2024
tvdeyen
added
backport-to-7.0-stable
This was referenced Apr 4, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The error message in Alchemy::Modules.validate_controllers_existence relies on the definition_hash variable to be present. Because it isn't, we get a NameError rather than the expected RuntimeError.