Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Preview Window width #2879

Merged
merged 1 commit into from
May 22, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 22, 2024

What is this pull request for?

We were recently fixing the transition of the width animation, but wasn't using the correct variable for the large viewport.

Checklist

We were recently fixing the transition of the width animation,
but wasn't using the correct variable for the large viewport.
@tvdeyen tvdeyen added backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable labels May 22, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner May 22, 2024 10:16
@tvdeyen tvdeyen enabled auto-merge May 22, 2024 10:16
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (7c1505e) to head (c423ef0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2879   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         230      230           
  Lines        6260     6260           
=======================================
  Hits         6006     6006           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit e7e037c into AlchemyCMS:main May 22, 2024
36 checks passed
@tvdeyen tvdeyen deleted the fix-width-of-preview-window branch May 22, 2024 10:21
@alchemycms-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
7.0-stable
7.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants