Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set input_type on Datetime ingredient editor #3002

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 28, 2024

What is this pull request for?

Since the Datetime ingredient stores date and time values it should be possible to set the input_type to either

  • time
  • date
  • datetime

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Since the Datetime ingredient stores date and time values
it should be possible to set the input_type to either

- time
- date
- datetime
@tvdeyen tvdeyen requested a review from a team as a code owner August 28, 2024 19:40
@tvdeyen tvdeyen added backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-6.1-stable backport-to-7.1-stable Needs to be backported to 7.1-stable backport-to-7.2-stable Needs to be backported to 7.2-stable labels Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (8d88024) to head (02a69a6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3002   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         233      233           
  Lines        6308     6308           
=======================================
  Hits         6086     6086           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 3513fd1 into main Aug 29, 2024
42 checks passed
@tvdeyen tvdeyen deleted the fix-datetime-editor-input_type branch August 29, 2024 08:32
@alchemycms-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
7.0-stable Backport failed because of merge conflicts
6.1-stable Backport failed because of merge conflicts
7.1-stable Backport failed because of merge conflicts
7.2-stable Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3002

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2024

💚 All backports created successfully

Status Branch Result
7.0-stable

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2024

💚 All backports created successfully

Status Branch Result
7.1-stable

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2024

💚 All backports created successfully

Status Branch Result
7.2-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable backport-to-7.2-stable Needs to be backported to 7.2-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants