Allow Rails 8.0 #3032
Merged
Allow Rails 8.0 #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 236 236
Lines 6347 6347
=======================================
Hits 6130 6130
Misses 217 217 ☔ View full report in Codecov by Sentry. |
|
This pull request has not seen any activiy in a long time. |
Rails 8.0 (the default Rails we use on CI) needs at least Ruby 3.2. We still support 3.1 and set the linter to check for Ruby 3.1 syntax.
Rails 8 needs at least Ruby 3.2
This needs to be defined as member in order to work with Rails 8
In Rails 8 the input helper for `<textarea>` HTML tag is finally called `textarea` and not `text_area` anymore.
mamhoff
approved these changes
Jan 6, 2025
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Allows to update to Rails 8.0