Move element hint into header (again) #3096
Merged
+16
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We moved the hint into the element body in 5bfa90f, but it is better in the header, because this information should only be visible if needed and not all the time.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3096 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 236 236
Lines 6334 6334
=======================================
Hits 6118 6118
Misses 216 216 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Nov 28, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Reverts 5bfa90f
We moved the hint into the element body in #2630 , but it is better in the header, because this information should only be visible if needed and not all the time.
Screenshots
Before
After
Checklist