[7.4-stable] Use turbo streams to update page from configure dialog #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows redirects after successful form submission, if we use `do_redirect_to` which is called by `render_errors_or_redirect`. (cherry picked from commit 48ac1fe)
This one was complex because we do a lot of different things dependent of where we are and what page type we update. The sitemap tree still needs to be replaced by calling a script, due to the fact that it is rendered with Handlerbars. Luckily Turbo let's us do this as well and can tackle that problem later. (cherry picked from commit c8e86ca)
We do not need this, if we make sure we do not use `rails-ujs` with `data-remote` in these forms. We can do that by passing `remote: false` to `alchemy_form_for`. (cherry picked from commit 5fac280)
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.4-stable #3128 +/- ##
===========================================
Coverage 96.47% 96.47%
===========================================
Files 237 237
Lines 6406 6410 +4
===========================================
+ Hits 6180 6184 +4
Misses 226 226 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.4-stable:Questions ?
Please refer to the Backport tool documentation