Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0-stable] Use safe redirect paths in admin redirects #3134

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 7, 2025

Backport

This will backport the following commits from main to 7.0-stable:

Questions ?

Please refer to the Backport tool documentation

This makes sure we only redirect internally in the /admin routing context
and redirect to a given safe fallback location or the default admin route.

(cherry picked from commit b4e7ca4)
app/controllers/alchemy/admin/base_controller.rb Dismissed Show dismissed Hide dismissed
app/controllers/alchemy/admin/pages_controller.rb Fixed Show resolved Hide resolved
This makes sure all redirects we do in the admin via do_redirect_to uses a safe redirect url.

(cherry picked from commit 7adefce)
@tvdeyen tvdeyen force-pushed the backport/7.0-stable/pr-3129 branch from 0c65119 to 6a0cbde Compare January 7, 2025 21:16
@tvdeyen tvdeyen force-pushed the backport/7.0-stable/pr-3129 branch from 0b1f1e7 to ff37ae1 Compare January 7, 2025 21:50
@tvdeyen tvdeyen merged commit 83bf9dc into 7.0-stable Jan 8, 2025
35 of 36 checks passed
@tvdeyen tvdeyen deleted the backport/7.0-stable/pr-3129 branch January 8, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant