Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job ReferenceReplacementJob is obsolete, Replacing it with running pipeline "replaceItemReferences", also creating helper method to update links when creating items of branch templates #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aokour
Copy link

@aokour aokour commented Nov 6, 2017

Job ReferenceReplacementJob is obsolete, Replacing it with running pipeline "replaceItemReferences", also creating helper method to update links when creating items of branch templates

…ne "replaceItemReferences", also creating helper method to update links when creating items of branch templates
@aokour
Copy link
Author

aokour commented Nov 6, 2017

As of Sitecore 8.2 Update 5, Job ReferenceReplacementJob is obsolete and sitecore asks to use pipeline "replaceItemReferences"instead, Also added support to update links for items created of branch items

@AlenPelin
Copy link
Owner

Thanks @aokour for contributing to the project. I had a quick look at your pull request and it seems you included too much changes so it is hard to see what is important.

May I ask you to keep only functional changes, so we can focus on important part?

P.S. Parts of these project already available in Sitecore 9.0.0 out of the box, others will be merged into next releases - so there is a chance for getting your contribution merged into the product itself :)

@aokour
Copy link
Author

aokour commented Nov 27, 2017

I will clean the pull request to only keep the functional changes and re-submit this again this week

@AlenPelin
Copy link
Owner

Thank you! I will look forward your update.

@cassidydotdk
Copy link

Yea there's definitely too much stuff in there. Kamsar's Branch presets and specific branch handling code has been included - none of this is necessary using SmartCommands.

@AlenPelin
Copy link
Owner

I noticed this project is getting more attention these days. I feel I need to revise and update it with current mainstream Sitecore 8.2+

@cassidydotdk
Copy link

The fundamental Sitecore problem these commands solve has been relevant since the dawn of time ;-)

I guess SXA drove them to bring the ReferenceReplacementJob into the core product. Now we just need them to realise what people actually expect when they're duplicating a tree with internal references.

@rbrunneratnamics
Copy link

I made a running version out of aoukur's version:
https://github.com/aokour/Sitecore-Smart-Commands
combined with an older version of your source AlenPelin. It runs on a Sitecore 8.2 solution, but would be nice to run on Sitecore 9+ too.

@cassidydotdk
Copy link

My version runs just fine on 9.1.1. Which is largely if not completely based on this branch. Mind you I've included the project on source level so I compile it against a 9.1.1.

9.2 will mostly involve changes around the ReferenceReplacementJob. Invoking it via reflection solves that problem in a cross version boundary.

@markgibbons25
Copy link

markgibbons25 commented Feb 18, 2021

In Sitecore 10 ReferenceReplacementJob is not obsolete, however I see that this PR is actually just using the ReplaceItemReferences pipeline which instantiates ReferenceReplacementJob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants