Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unify part of the repository interfaces #1231

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: unify part of the repository interfaces #1231

wants to merge 7 commits into from

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented Jan 28, 2025 •
edited
Loading

Description

  • method calls should fail on retrieving data when the type is not the given type
  • fix typing for run&evaluation repositories, was missing failing types

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA changed the title feat: unify repository interfaces feat: unify part of the repository interfaces Jan 28, 2025
@NiklasKoehneckeAA NiklasKoehneckeAA marked this pull request as ready for review January 29, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhammeralephalpha maxhammeralephalpha Awaiting requested review from maxhammeralephalpha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NiklasKoehneckeAA