Fix a bug that caused a crash when retrieving the text of the last pa…

…ge of the entire document on iOS
AlessioLuciani · Mar 30, 2020 · eb8e7d8 · eb8e7d8
1 parent 7da63b7
commit eb8e7d8
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.1.1
+
+* An issue that caused a crash on iOS, when retrieving the text of the last page of the entire document, has been fixed.
+
+
 ## 0.1.0
 
 * The plugin is ready to be used.

diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@ Add this to your package's `pubspec.yaml` file:
 
 ```yaml
 dependencies:
-  pdf_text: ^0.1.0
+  pdf_text: ^0.1.1
 ```
 
 ## Usage
@@ -55,6 +55,11 @@ Read the text of a page of the document:
 String pageText = await page.text;
 ```
 
+## Functioning
+
+This plugin applies lazy loading for the text contents of the pages. The text is cached page per page. When you request the text of a page for the first time, it is parsed and stored in memory, so that the second access will be faster. Anyway, the text of pages that are not requested is not loaded. This mechanism
+allows you not to waste time loading text that you will probably not use. When you request the text content of the entire document, only the pages that have not been loaded yet, are then loaded.
+
 ## Public Methods
 
 ### PDFDoc

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -122,7 +122,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.1.0"
+    version: "0.1.1"
   petitparser:
     dependency: transitive
     description:

diff --git a/ios/Classes/SwiftPdfTextPlugin.swift b/ios/Classes/SwiftPdfTextPlugin.swift
@@ -70,7 +70,7 @@ public class SwiftPdfTextPlugin: NSObject, FlutterPlugin {
         if doc == nil {
             return
         }
-        let text = doc!.page(at: pageNumber)!.string
+        let text = doc!.page(at: pageNumber-1)!.string
         DispatchQueue.main.sync {
             result(text)
         }
@@ -87,7 +87,7 @@ public class SwiftPdfTextPlugin: NSObject, FlutterPlugin {
         }
         var missingPagesTexts = [String]()
         for pageNumber in missingPagesNumbers {
-            missingPagesTexts.append(doc!.page(at: pageNumber)!.string!)
+            missingPagesTexts.append(doc!.page(at: pageNumber-1)!.string!)
         }
         DispatchQueue.main.sync {
             result(missingPagesTexts)

diff --git a/lib/pdf_text.dart b/lib/pdf_text.dart
@@ -108,7 +108,7 @@ class PDFPage {
     if (_text == null) {
       try {
         _text = await _channel.invokeMethod('getDocPageText', {"path": _parentDoc._file.path,
-            "number": _number});
+            "number": number});
       } on Exception catch (e) {
         return Future.error(e);
       }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: pdf_text
 description: A Flutter plugin used to extract text from PDF documents.
-version: 0.1.0
+version: 0.1.1
 homepage: https://github.com/AlessioLuciani/flutter-pdf-text
 
 environment: