Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes parenthesis [#33] #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marknuzz
Copy link

@marknuzz marknuzz commented Apr 9, 2016

No description provided.

@marknuzz
Copy link
Author

marknuzz commented Apr 9, 2016

There is some refactoring in here as well, to encapsulate some of the complexity.

@marknuzz
Copy link
Author

Just noticed issues with this, based on the unit testing. Will have a fix.

@marknuzz
Copy link
Author

Looks like the quick and dirty parser is not able to handle both Math functions and attached properties, due to the parenthesis needing to be handled differently. Context-dependent parsing would need to be employed, which make it more difficult. Still going to work on it.

@marknuzz
Copy link
Author

The tests now pass, and the parser is more sophisticated now. Should pave the way for more complex calculations if those features should be needed at a later time

@marknuzz
Copy link
Author

Might need to be cleaned up a bit, I didn't have time to really polish it, but added comments where I could

@Alex141
Copy link
Owner

Alex141 commented Apr 12, 2016

Thanks, good job! I review this soon, sorry, haven't enough time now

@marknuzz
Copy link
Author

marknuzz commented May 6, 2016

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants