-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes parenthesis [#33] #35
base: master
Are you sure you want to change the base?
Conversation
There is some refactoring in here as well, to encapsulate some of the complexity. |
Just noticed issues with this, based on the unit testing. Will have a fix. |
Looks like the quick and dirty parser is not able to handle both Math functions and attached properties, due to the parenthesis needing to be handled differently. Context-dependent parsing would need to be employed, which make it more difficult. Still going to work on it. |
The tests now pass, and the parser is more sophisticated now. Should pave the way for more complex calculations if those features should be needed at a later time |
Might need to be cleaned up a bit, I didn't have time to really polish it, but added comments where I could |
Thanks, good job! I review this soon, sorry, haven't enough time now |
Any news? |
No description provided.