Add multiple RK support. #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please write a test or provide a test data for such cases? |
|
Done! There was also an issue where shared string tables of length 0 would cause an exception, so I added a guard for that as it was breaking the test. |
|
Are those tests good enough? |
|
Yup, but what's the deal with |
|
Hmm, I think I might've accidentally marked it as changed. I think it's saying there's nothing different (and the tests still pass), but I can revert that if you're worried. |
|
Revert pls and i'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple RK blocks. I see there's another PR open for this, but it's so old I figured it was okay to open a new one.