-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Updates nock to v13 #211
base: master
Are you sure you want to change the base?
Conversation
Hey! Changelogs info seems to be missing or might be in incorrect format. |
Thanks for the PR! This section of the codebase is owner by https://github.com/AlexRogalskiy/ - if they write a comment saying "LGTM" then it will be merged. |
Thanks for opening an issue! Make sure you've followed CONTRIBUTING.md. |
Hello from PR HelperIs your PR ready for review and processing? Mark the PR ready by including If you still have work to do, even after marking this ready. Put the PR on hold by including |
Mega-Linter status: ✅ SUCCESSSee errors details in artifact Mega-Linter reports on GitHub Action page |
69a9a85
to
fd45bc4
Compare
fd45bc4
to
83f472d
Compare
83f472d
to
4c02183
Compare
4c02183
to
4dce8d1
Compare
4dce8d1
to
6628ec6
Compare
Pull request by bot. No need to analyze |
6628ec6
to
83cf6e1
Compare
83cf6e1
to
816c70e
Compare
816c70e
to
b438b6a
Compare
b438b6a
to
de10879
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
de10879
to
fe45172
Compare
fe45172
to
b3b3394
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
b3b3394
to
6eec2c0
Compare
6eec2c0
to
deeb979
Compare
deeb979
to
89ff484
Compare
f24a0ed
to
b2eaa31
Compare
b2eaa31
to
0e856d3
Compare
0e856d3
to
b5d9a8a
Compare
b5d9a8a
to
87676bc
Compare
87676bc
to
978c5ab
Compare
978c5ab
to
1736bb8
Compare
1736bb8
to
fcda0f4
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fcda0f4
to
902a216
Compare
f45704a
to
902a216
Compare
This PR contains the following updates:
8.2.2
->13.5.6
Release Notes
nock/nock (nock)
v13.5.6
Compare Source
Bug Fixes
v13.5.5
Compare Source
v13.5.4
Compare Source
Bug Fixes
fs.createReadStream
lazily (#2357) (ba9fc42)v13.5.3
Compare Source
Bug Fixes
v13.5.2
Compare Source
Bug Fixes
activeMocks()
andpendingMocks()
(#2356) (7e957b3)v13.5.1
Compare Source
Bug Fixes
v13.5.0
Compare Source
Features
Scope#clone()
method (#2564) (65385f7)v13.4.0
Compare Source
Features
context.query()
to nock back (#2553) (617511f)v13.3.8
Compare Source
Bug Fixes
filteringBodyRequest
(#2552) (0b18d07)v13.3.7
Compare Source
Reverts
v13.3.6
Compare Source
Bug Fixes
semver
usage (#2531) (f7216e9)v13.3.5
Compare Source
Bug Fixes
v13.3.4
Compare Source
Bug Fixes
nock(new URL('https://example.test/'))
(#2526) (6987327)v13.3.3
Compare Source
Bug Fixes
v13.3.2
Compare Source
Bug Fixes
nock.removeInterceptor
can remove the wrong Intercept (#2497) (92de0de)v13.3.1
Compare Source
Bug Fixes
v13.3.0
Compare Source
Features
v13.2.9
Compare Source
Bug Fixes
v13.2.8
Compare Source
Bug Fixes
Definition#scope
andDefinition#path
(#2374) (2edf341)v13.2.7
Compare Source
Bug Fixes
InterceptedRequestRouter.handleWrite
arity issue (#2371) (7f21d0c)v13.2.6
Compare Source
Reverts
v13.2.5
Compare Source
Bug Fixes
v13.2.4
Compare Source
Bug Fixes
v13.2.3
Compare Source
Bug Fixes
v13.2.2
Compare Source
Bug Fixes
allowUnocked
not working with regex host + request body match (#2277) (ac7b4fd)v13.2.1
Compare Source
Bug Fixes
update
type for record mode (#2250) (e8f23b1), closes #2241v13.2.0
Compare Source
Features
update
mode (#2241) (1cb4880)v13.1.4
Compare Source
Bug Fixes
v13.1.3
Compare Source
Bug Fixes
v13.1.2
Compare Source
Bug Fixes
v13.1.1
Compare Source
Bug Fixes
v13.1.0
Compare Source
Features
v13.0.11
Compare Source
Bug Fixes
v13.0.10
Compare Source
Bug Fixes
v13.0.9
Compare Source
Bug Fixes
destroyed
attribute (#2152) (b9758c8)v13.0.8
Compare Source
Bug Fixes
v13.0.7
Compare Source
Bug Fixes
v13.0.6
Compare Source
Bug Fixes
v13.0.5
Compare Source
Bug Fixes
req.end
multiple times (20e9f8a), closes /github.com/nodejs/node/blob/39a7f7663e8f70fc774105d8fa41b8e4cc69149f/lib/_http_outgoing.js#L816v13.0.4
Compare Source
Bug Fixes
v13.0.3
Compare Source
Bug Fixes
v13.0.2
Compare Source
Bug Fixes
v13.0.1
Compare Source
Bug Fixes
v13.0.0
Compare Source
See the Migration Guide
Breaking changes
Scope.log
has been removed. Use thedebug
library when debugging failed matches.socketDelay
has been removed. UsedelayConnection
instead.delay
,delayConnection
, anddelayBody
are now setters instead of additive.When recording, skipping body matching using
*
is no longer supported bynock.define
.Set the definition body to
undefined
instead.ClientRequest.abort()
has been updated to align with Node's native behavior.This could be considered a feature, however, it created some subtle differences that are not backwards compatible. Refer to the migration guide for details.
Playback of a mocked responses will now never happen until the 'socket' event is emitted.
v12.0.3
Compare Source
Bug Fixes
v12.0.2
Compare Source
Bug Fixes
v12.0.1
Compare Source
Bug Fixes
v12.0.0
Compare Source
BREAKING CHANGES
nock
global fromcleanAll()
(#1872) (0a4a944), closes #1872When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
Features
enableNetConnect()
(#1889) (7f9e26c)v11.9.1
Compare Source
Bug Fixes
v11.9.0
Compare Source
Features
enableNetConnect()
(#1889) (566461b)v11.8.2
Compare Source
Bug Fixes
v11.8.1
Compare Source
Bug Fixes
v11.8.0
Compare Source
Bug Fixes
Features
v11.7.2
Compare Source
Bug Fixes
v11.7.1
Compare Source
Bug Fixes
v11.7.0
Compare Source
Features
currentMode
(#1794) (ba60fd2), closes /github.com/nock/nock/blob/master/lib/back.js#L282v11.6.0
Compare Source
Features
v11.5.0
Compare Source
Features
v11.4.0
Compare Source
Features
v11.3.6
Compare Source
Bug Fixes
v11.3.5
Compare Source
Bug Fixes
v11.3.4
Compare Source
Bug Fixes
v11.3.3
Compare Source
Bug Fixes
v11.3.2
: v11Compare Source
Upgrading from Nock 10 to Nock 11
Bug fixes and internal improvements
Nock 11 includes many under-the-hood improvements, including a fully offline
test suite and 100% test coverage. The codebase was also converted to ES6
syntax and formatted with Prettier. Leaning on the test coverage, some
substantial refactors have begun.
Many bug fixes are included. See the detailed changelog below or the
compare view for details.
Fabulous new features for developers
http.request
signatures added in Node 10.9using e.g.
.conditionally(() => true)
afterRecord()
post-processing hook. When
afterRecord()
returns a string, therecorder will no longer attempt to re-stringify it. (Added in v11.3)
.reply()
can now be async/promise-returning..reply()
or.defaultReplyHeaders()
,can now be done consistently using an object, Map, or flat array.
Breaking changes
For many developers no code changes will be needed. However, there are several
minor changes to the API, and it's possible that you will need to update your
code for Nock to keep working properly. It's unlikely that your tests will
falsely pass; what's more probable is that your tests will fail until the
necessary changes are made.
Nock 11 requires Node 8 or later. Nock supports and tests all the "current"
and "maintenance" versions of Node. As of now, that's Node 8, 10, and 12.
In Nock 10, when
reply()
was invoked with a function, the return values werehandled ambiguously depending on their types.
Consider the following example:
In Nock 10, the 200 was ignored, the 500 was interpreted as the status
code, and the body would contain
'hello world'
. This caused problemswhen the goal was to return a numeric array, so in Nock 11, the 200 is
properly interpreted as the status code, and
[500, 'hello world']
as thebody.
These are the correct calls for Nock 11:
The
.reply()
method can be called with explicit arguments:It can be called with a status code and a function that returns an array:
Alternatively the status code can be included in the array:
.reply()
can also be called with anasync
or promise-returning function. Thesignatures are identical, e.g.
Finally, an error-first callback can be used, e.g.:
In Nock 10, errors in user-provided reply functions were caught by Nock, and
generated HTTP responses with status codes of 500. In Nock 11 these errors
are not caught, and instead are re-emitted through the request, like any
other error that occurs during request processing.
Consider the following example:
When
fs.readFile()
errors in Nock 10, a 500 error was emitted. To get thesame effect in Nock 11, the example would need to be rewritten to:
When
.reply()
is invoked with something other than a whole number statuscode or a function, Nock 11 raises a new error Invalid ... value for status code.
Callback functions provided to the
.query
method now receive the result ofquerystring.parse
instead ofqs.parse
.In particular,
querystring.parse
does not interpret keys with JSONpath notation:
In Nock 10, duplicate field names provided to the
.query()
method weresilently ignored. We decided this was probably hiding unintentionally bugs
and causing frustration with users. In Nock 11, attempts to provide query
params more than once will throw a new error
Query parameters have aleady been defined. This could happen by calling
.query()
twice, or by calling.query()
after specifying a literal querystring via the path.
Paths in Nock have always required a leading slash. e.g.
In Nock 10, if the leading slash was missing the mock would never match. In
Nock 11, this raises an error.
The
reqheaders
parameter should be provided as a plain object, e.g.nock('http://example.com', { reqheaders: { X-Foo: 'bar' }})
. When theheaders are specified incorrectly as e.g.
{ reqheaders: 1 }
, Nock 10 wouldbehave in unpredictable ways. In Nock 11, a new error
Headers must be provided as an object is thrown.
In Nock 10, the
ClientRequest
instance wrapped the nativeon
methodand aliased
once
to it. In Nock 11, this been removed andrequest.once
will correctly call registered listeners...once.
In Nock 10, when the method was not specified in a call to
nock.define()
,the method would default to
GET
. In Nock 11, this raises an error.In very old versions of nock, recordings may include a response status
code encoded as a string in the
reply
field. In Nock 10 these strings couldbe non-numeric. In Nock 11 this raises an error.
Updates to the mock surface
the overrides to
request.end()
, includingrequest.end(cb)
in Node 12..destroy()
methodare propagated correctly. (Added in v11.3)
.complete
property is set whenending the response.
unref()
function(which does nothing).
If you discover bugs in this release, please open a bug report on the Nock repo. 🐛
Detailed changelog
BREAKING CHANGES
Interceptor.query
twice throws an error.query
method throws an error instead of ignoring subsequent values.
Features
conditionally()
(#1488) (24e5b47)IncomingMessage.client
for parity with real requests (dc71a3b), closes /github.com/nodejs/node/blob/2e613a9c301165d121b19b86e382860323abc22f/lib/_http_incoming.js#L67unref
to Socket (#1612) (a75f49f)2e56fb0
), closes #1670de9c40b
), closes #1669Bug Fixes
req.end(cb)
compatibility with Node 12 (#1551) (31623fb).matchHeader()
withallowUnmocked
(#1480) (d6667f0)req.end(cb)
; prevent TypeError in Node 12 (#1547) (9a494da), closes #1509new ClientMessage()
is invoked with no options (#1386) (6d2a312)Code Refactoring
v11.3.1
Compare Source
v11.3.0
Compare Source
v11.2.0
Compare Source
v11.1.0
Compare Source
v11.0.0
Compare Source
v10.0.6
Compare Source
Bug Fixes
v10.0.5
Compare Source
Bug Fixes
v10.0.4
Compare Source
Bug Fixes
v10.0.3
Compare Source
Bug Fixes
v10.0.2
Compare Source
Bug Fixes
v10.0.1
Compare Source
Bug Fixes
v10.0.0
Compare Source
BREAKING CHANGES
There is no intentional change that breaks usage in Node 4, but as we
stop testing in this no longer supported Node version we recommend to
no update nock if you still rely on Node 4.
The reason why we decided to go ahead and make a breaking version
release is that it became increasingly harder to update dependencies
to the latest versions as they also drop support for Node 4.
Bug Fixes
Code Refactoring
Continuous Integration
v9.6.1
Compare Source
Bug Fixes
v9.6.0
Compare Source
Features
v9.5.0
Compare Source
Features
v9.4.4
Compare Source
Bug Fixes
v9.4.3
Compare Source
Bug Fixes
v9.4.2
Compare Source
Bug Fixes
v9.4.1
Compare Source
Bug Fixes
v9.4.0
Compare Source
Features
v9.3.3
Compare Source
Bug Fixes
v9.3.2
Compare Source
Bug Fixes
v9.3.1
Compare Source
Bug Fixes
aborted
property on http request (#1134) (aaa9a56)v9.3.0
Compare Source
Features
v9.2.6
Compare Source
Bug Fixes
v9.2.5
Compare Source
Bug Fixes
v9.2.4
Compare Source
Bug Fixes
v9.2.3
Compare Source
Bug Fixes
v9.2.2
Compare Source
Bug Fixes
Configuration
📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone Europe/Moscow, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.