arg fish effect and other shaders #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3165b4.
when multiple fish is present, all the effects are on the first one, no bz test
bz still doesn't work, so no test
brain smol xdx
|
the fact that most of the effects are hard coded and assigned at vfxMaterialHolder, causes all the images and etc. used by materials to be included in assets, I should probably do something about that |
Alexejhero
reviewed
Dec 12, 2023
Alexejhero
approved these changes
Dec 12, 2023
Alexejhero
reviewed
Dec 12, 2023
|
Let me know when this PR is ready and I will merge it |
|
should be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sending this from my phone xdx 😨 , I put the effect ✨ in hiyori prefab, on a separate object 🏢, and everything should be good to go 👍, just build the assets 😊.
I did my best 💪 to provide some explanation 🤔 on other effects if they might be useful. also, my tri inspector was on a different commit for some reason 😞, but I hope it's not a big issue (Clueless) . I might not be able to make it to pr-review, so lmk if anything needs to be changed.