Move sounds to FMOD #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore sample rate for jukebox track(s)
(it would work a lot better if we had the right project structure)
fix sn fix holster fix 2d/3d fix "disable X sounds" options not being respected
fix inventory sounds getting muffled indoors move ermfish to "amphibious" bus so they can play world sounds above water fix draw sound playing on pickup
attach cook noise to the fabricator un-forgor the docstring make pickup stop world noises make eating stop inventory noises
fix cooked/cured tutel not having eat sounds
|
what am i even supposed to review here |
|
yeah it's a bit much sorry |
|
do you care if i just merge this? i've tested the sounds pretty extensively i mean just look at this isn't it tantalising |
Alexejhero
requested changes
Dec 20, 2023
feedback resolved :Tomfoolery:
Alexejhero
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will:
Come to the FMOD side, we have parameters, effects, mixing, and ---> hot reload <---
I fixed an issue entirely in FMOD Studio, pressed F7, and tested the fix without having to restart Subnautica. it's so good