Fix integer parsing correctness issues. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also added the test cases provided and with the simpler overflow detection using |
This avoids using an intermediary unsigned type and then post-overflow validation, which avoids issues with overflowing checks wrapping to above our min value. This does not meaningfully affect performance, despite simplifying the type checks dramatically. The float and integer parsing benchmarks are comparable to before, with the integer parsing being slower than core for simple integers but much faster for larger/random integers due to multi-digit parsing. - Closes #91
Alexhuszagh
force-pushed
the
issue_91
branch
from
e07f4ff to
fb3e059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids using an intermediary unsigned type and then post-overflow validation, which avoids issues with overflowing checks wrapping to above our min value. This does not meaningfully affect performance, despite simplifying the type checks dramatically. The float and integer parsing benchmarks are comparable to before, with the integer parsing being slower than core for simple integers but much faster for larger/random integers due to multi-digit parsing.