Remove LTO for OSS-Fuzz Dependencies #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
force-pushed
the
ossfuzz
branch
2 times, most recently
from
74d6b9b to
728b8fb
Compare
Get rid of LTO, which has a bug with `__sancov_gen_` being an undefined symbol. Also, this updates the macro use to directly import the symbols to reflect more modern Rust design.
DavidKorczynski
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Oct 7, 2024
This unpins the image for `rust-lexical`, due to patches in the fuzz targets Cargo.toml to remove LTO from the release profile. Related to: - Alexhuszagh/rust-lexical/issues/164 - Alexhuszagh/rust-lexical/issues/166 - #12365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fuzzing dependencies and logic.
Gets rid of LTO, which has a bug with
__sancov_gen_being an undefined symbol. Also, this updates the macro use to directly import the symbols to reflect more modern Rust design.Closes #164