-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance issues in float parsing. #210
Conversation
b1ede49
to
a80aa9b
Compare
According to my benchmarks, the ones in fast-float2 against the latest commit are: Canada
Mesh
Random Uniform
Other benches in lexical show similar results (one uses criterion, one is a straight executable), where the performance is practically identical for fast-cast datasets, but otherwise lexical outperforms for near-halfway cases. The performance for the Earth dataset is particularly a lot faster than fast-float2, which was unexpected since it's very simple floats like to be covered by the fast case (can be represented entirely by machine floats). |
This fixes a few performance issues due to a lack of inlining on the Eisel-Lemire algorithm.