Ring: Fix snapshot producer MarshalJSON and prevent nil reference during stop #1568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR, I forgot to correctly execute MarshalJSON on a snapshot producer. As a result, for example, the
/probe
call didn't work on it.Also, during my testing, I noticed that in rare cases the following error occurs:
This PR should fix this by no longer setting the producer to
nil
during a stop (as is the case with other producers)