Adding aya and sura pages, Issue #499 #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former-commit-id: cb17d19
Former-commit-id: 328dcbd
Former-commit-id: ff31cc4
… results Former-commit-id: f1526a6
Former-commit-id: 0e29a62
Former-commit-id: e78858d
Former-commit-id: 167bf8e
Searcher should be closed after each search operation
Searcher should be closed after each search operation Former-commit-id: ee87455
Former-commit-id: 888c439
Former-commit-id: a749a35
Former-commit-id: 9e6a02e
Former-commit-id: e60c4a7
Former-commit-id: b696cd1
…to fix_arabic_keyboard
…ix_arabic_keyboard
Fix closing tags and add rich data for organization, products, aya results list
Fix sitemap and implement it the same as opensearch.xml and robots.txt fix Alfanous-team#492
Jinja-HTML template validation
Move sitemap file to the root directory Allow crawling bot to see jos2 main page
|
@assem-ch put back main tag. One thing are you following any coding style conventions. It will help much when trying to debug code. I opened the PR to start working the feature. |
|
@sneetsher PEP8 for python, HTML5 conventions for html, for Js no conventions for now. I can help you to define what should be on the pages, and we can delegate the design specs to a designer. |
Remove the note for help and remove downloads for source forge
|
Yes, if you could define what we should have in those pages, in #499 . For style, I try to learn and apply as I go from https://google.github.io/styleguide/ beside those you mention. which are practical rules. |
Clean up setting file style PEP8
|
Here is a quick spec for the ayah detailed page: |
Add some generic block to base template, prepare to refracture Add new template tag lineless to cleanup empty lines from rendered output Some cleanup of templates and python style
|
The aya page now is partially implemented but as a search query: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.