Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-3106] Removed special characters from yaml files #220

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

vedantmehra9
Copy link
Contributor

@vedantmehra9 vedantmehra9 commented Jan 7, 2025

https://hyland.atlassian.net/browse/APPS-3106
Add Alfresco Java SDK Docs as part of nexus repository artifacts

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@SathishK-T SathishK-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kavitshah-gl kavitshah-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@mohit-singh4 mohit-singh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@damianujma damianujma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
HTML entities are not parsed in the Swagger Editor. Did you test it?

Copy link
Contributor

@pzhyland pzhyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @damianujma . You cannot fix javadoc by braking the swagger UI. Please think of a different solution which works fine for both javadoc and swagger ui.

@vedantmehra9 vedantmehra9 merged commit beb3212 into master Jan 20, 2025
6 checks passed
@vedantmehra9 vedantmehra9 deleted the apps-3106_Remove_Character_Java_Doc branch January 20, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants