This repository has been archived by the owner on May 18, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add example unit test for running Activiti 7 process #315
base: master
Are you sure you want to change the base?
feat: Add example unit test for running Activiti 7 process #315
Changes from 1 commit
bb9768d
69bc9d3
231c352
aeb48cb
80fbca0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be easier to add the dependency to
activiti-cloud-starter-connector
in test scope so you can use the provided IntegrationResultSender?activiti-cloud-starter-connector
is also bringingIntegrationResultBuilder
: https://github.com/Activiti/ttc-connectors-dummytwitter/blob/master/src/main/java/org/activiti/cloud/connectors/twitter/connectors/TweetConnector.java#L60There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erdemedeiros I have tried to add starter connector dependency in test scope. It is causing a problem with overriding bean definitions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After enabling bean override, it blows up with the error due to component scan:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erdemedeiros The
activiti-cloud-starter-connector
module component scan problem is fixed now. I have updated unit test example to useIntegrationResultBuilder
and removed hacks from previous commits.