Skip to content

Commit

Permalink
Change subprocess.run check
Browse files Browse the repository at this point in the history
  • Loading branch information
s5u13b committed Nov 28, 2024
1 parent 0d10de0 commit d28afc0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@


def pytest_sessionstart(session):
subprocess.run(["ray", "stop"], check=True, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
subprocess.run(["ray", "start", "--head", "--disable-usage-stats", "--port=6379"], check=True,
subprocess.run(["ray", "stop"], check=False, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
subprocess.run(["ray", "start", "--head", "--disable-usage-stats", "--port=6379"], check=False,
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)

def pytest_sessionfinish(session, exitstatus):
subprocess.run(["ray", "stop"], check=True, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
subprocess.run(["ray", "stop"], check=False, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)

@pytest.fixture
def setup_ray_env():
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e_test/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ def cleanup_ray_env():
cleanup_ray_env_func()

def shutdown_llumnix_service_func():
subprocess.run('pkill -f llumnix.entrypoints.vllm.api_server', shell=True, check=True)
subprocess.run('pkill -f benchmark_serving.py', shell=True, check=True)
subprocess.run('pkill -f llumnix.entrypoints.vllm.api_server', shell=True, check=False)
subprocess.run('pkill -f benchmark_serving.py', shell=True, check=False)

@pytest.fixture
def shutdown_llumnix_service():
Expand Down

0 comments on commit d28afc0

Please sign in to comment.