Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add unittest for llumlet and backends #14

Merged
merged 9 commits into from
Aug 26, 2024
Merged

[CI] Add unittest for llumlet and backends #14

merged 9 commits into from
Aug 26, 2024

Conversation

ZeldaHuang
Copy link
Contributor

Add tests for LLMEngineLlumnix、Llumlet、SchedulerLlumnix、BlockManagerLlumnix、MigrationCoordinator

zhypku
zhypku reviewed Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@zhypku zhypku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there exists any randomness in these tests? That is, a test is not guaranteed to pass, depending on the real-time execution. For example, a function executing too fast/slow would make the test fail.

tests/backends/vllm/test_migration.py Outdated Show resolved Hide resolved
tests/llumlet/test_migration_coordinator.py Outdated Show resolved Hide resolved
KuilongCui
KuilongCui reviewed Aug 26, 2024
View reviewed changes
tests/backends/vllm/test_migration.py Outdated Show resolved Hide resolved
tests/backends/vllm/test_migration.py Outdated Show resolved Hide resolved
tests/backends/vllm/test_migration.py Outdated Show resolved Hide resolved
@ZeldaHuang ZeldaHuang merged commit 70b8c9a into main Aug 26, 2024
4 checks passed
@ZeldaHuang ZeldaHuang deleted the llumlet-tests branch August 26, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuilongCui KuilongCui KuilongCui left review comments

@s5u13b s5u13b s5u13b approved these changes

@zhypku zhypku zhypku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeldaHuang @zhypku @s5u13b @KuilongCui