[Misc] Update instance info of engine in a timely manner #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhypku
reviewed
Aug 27, 2024
zhypku
approved these changes
Aug 27, 2024
KuilongCui
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we updated the instance info of the engine after each step. Instance info is used by the global scheduler to get the instance's memory usage, etc. However, the actual time point of instance memory update occurs when the scheduler schedules the requests before each step. So, instead of updating the instance info after each step, this pr implements the scheduler to call back the engine to update instance info right after scheduling requests. With this change, the global scheduler can get more timely instance info, which could benefit dynamic scheduling.
Also, I fix some arguments description and TODOs passingly in this pr.