Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Add "LlumnixRequest" class and refactor api #21

Merged
merged 9 commits into from
Sep 2, 2024
Merged

[Misc] Add "LlumnixRequest" class and refactor api #21

merged 9 commits into from
Sep 2, 2024

Conversation

ZeldaHuang
Copy link
Contributor

@ZeldaHuang ZeldaHuang commented Aug 28, 2024 •
edited
Loading

  1. Replace MigratingRequest with LlumnixRequest, maintain migration-related or llumnix args , backend engine should implements its own request class (likeSequenceGroupLlumnix in vllm backend)
  2. Move migration-policy function to LocalMigrationScheduler
  3. Fix some bugs in migration.
  4. Update unitests.

s5u13b
s5u13b reviewed Aug 29, 2024
View reviewed changes
llumnix/llumlet/llumlet.py Outdated Show resolved Hide resolved
@ZeldaHuang ZeldaHuang requested a review from s5u13b August 30, 2024 09:19
s5u13b
s5u13b reviewed Aug 30, 2024
View reviewed changes
llumnix/llumlet/local_migration_scheduler.py Outdated Show resolved Hide resolved
llumnix/llumlet/local_migration_scheduler.py Show resolved Hide resolved
llumnix/llumlet/request.py Show resolved Hide resolved
Makefile Show resolved Hide resolved
@ZeldaHuang
refactor
3c92ed6 
fix

fix pylint

update

fix

add todo

add todo

fix
@ZeldaHuang
update
59f3a63
@ZeldaHuang
fix
41fe8b2
KuilongCui
KuilongCui reviewed Sep 2, 2024
View reviewed changes
tests/backends/vllm/test_migration.py Outdated Show resolved Hide resolved
tests/backends/vllm/test_migration.py Show resolved Hide resolved
llumnix/backends/vllm/llm_engine.py Show resolved Hide resolved
llumnix/backends/vllm/llm_engine.py Show resolved Hide resolved
llumnix/backends/vllm/llm_engine.py Show resolved Hide resolved
llumnix/llumlet/request.py Show resolved Hide resolved
llumnix/llumlet/local_migration_scheduler.py Show resolved Hide resolved
s5u13b
s5u13b approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@s5u13b s5u13b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeldaHuang ZeldaHuang merged commit f6bbb18 into main Sep 2, 2024
4 checks passed
@ZeldaHuang ZeldaHuang deleted the misc branch September 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuilongCui KuilongCui KuilongCui approved these changes

@s5u13b s5u13b s5u13b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeldaHuang @s5u13b @KuilongCui