Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][CI] Fix unittest errors caused by incorrect ray actors management #23

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

s5u13b
Copy link
Contributor

@s5u13b s5u13b commented Aug 29, 2024

  1. Fix unittest errors cause by incorrect ray actors management
    Llumnix‘s unit test raises some errors due to incorrect ray actors management. Detached actors are not killed after some test function and therefore make other test functions raise errors. This pr adds setup_ray_env pytest fixture for ray cluster management in unit test. We can pass this fixture whenever we need to create actors(that is, use ray) in test functions.
  2. Fix unit test errors caused by not adding update_instance_info callback function to the scheduler.

@s5u13b s5u13b changed the title [BugFix][CI] Fix unittest errors cause by incorrect ray actors management [BugFix][CI] Fix unittest errors Aug 29, 2024
@s5u13b s5u13b changed the title [BugFix][CI] Fix unittest errors [BugFix][CI] Fix unittest errors cause by incorrect ray actors management Aug 29, 2024
@s5u13b s5u13b changed the title [BugFix][CI] Fix unittest errors cause by incorrect ray actors management [BugFix][CI] Fix unittest errors caused by incorrect ray actors management Aug 29, 2024
@s5u13b s5u13b merged commit d05adc8 into main Aug 30, 2024
4 checks passed
@s5u13b s5u13b deleted the fix-unittest branch August 30, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants