-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hybrid trace and add benchmark #48
base: main
Are you sure you want to change the base?
Conversation
yitongh
commented
Jan 8, 2025
•
edited
Loading
edited
- support hybrid trace
- register FA as PyTorch op
- add llm benchmark
- move patch to accelerate.apply_patch
d604981
to
ddc20d1
Compare
|
||
declare -A BACKAND_PARAMS=( | ||
["torchacc"]="--backend lazy" | ||
["hybridtrace"]="--backend lazy --hybrid_trace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little strange to specify both eager/lazy backend and partial_compile/hybrid_trace in the command. Can we hide the backend option in the command(reserve in the Backendconfig)?
for example, --lazy represents LTC trace and lazy mode, --eager represents eager mode and cuda native, --hybridtrace represents lazy mode but hybridtrace, --partial_compile represents eager mode but dynamo + xla.
We only need to check if xla is aviliable in the environment for lazy mode.
What's more, we need add comments or docs for these options.