nds: add BlocksDS port #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asiekierka
force-pushed
the
port-blocksds
branch
from
4d8645e to
2f50dce
Compare
|
Updated, but temporarily blocked by blocksds/sdk#90 , as well as more |
|
The final issue with this port that I'm aware of is solved by blocksds/libnds#45 |
AliceLR
reviewed
Dec 6, 2023
Makefile
Outdated
| # As does BlocksDS, currently | ||
| # | ||
| ifeq (${BUILD_NDS_BLOCKSDS},1) | ||
| CFLAGS += -Wno-strict-prototypes -Wno-pedantic -Wno-undef -Wno-declaration-after-statement |
There was a problem hiding this comment.
Checking on the differences between the NDS hack and the BlocksDS hack here:
-Wno-undef- does using-isystemfor the SDK includes in the BlocksDS Makefile fragment fix the need for this?-Wno-declaration-after-statement- what is this for? If it's in MZX it'd be better to fix the affected code, since MSVC and old compilers don't like declarations after statements.
There was a problem hiding this comment.
Re -Wno-undef: Apparently, this has been fixed in a later BlocksDS version altogether.
Re -Wno-declaration-after-statement:
CC src/counter.c
In file included from /home/asie/toolchains/blocksds/sdk/libs/libnds/include/nds/arm9/boxtest.h:19,
from /home/asie/toolchains/blocksds/sdk/libs/libnds/include/nds.h:134,
from src/compat.h:91,
from src/board.h:23,
from src/counter.c:32:
/home/asie/toolchains/blocksds/sdk/libs/libnds/include/nds/arm9/videoGL.h: In function 'glCallList':
/home/asie/toolchains/blocksds/sdk/libs/libnds/include/nds/arm9/videoGL.h:856:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
856 | u32 count = *list++;
| ^~~
It's in BlocksDS. There's an open issue to fix all such warnings, but it's a lot of work. I'll probably fast-track this one, but only for the next release: blocksds/sdk#4
… not, mimicking BlocksDS 0.10.0+ Makefile logic
asiekierka
force-pushed
the
port-blocksds
branch
from
181e896 to
bc25bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference over the previous toolchain is ~120K smaller binaries, faster memcpy/memset, and the many bugfixes accumulated in the last few weeks. However, even though it appears to be stable (perhaps even better) in testing, as BlocksDS's future is less certain - think "Lindy effect" - I think it's worth keeping it as a separate port for the time being.