Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testworlds PID check and ps edge case found using chroot. #412

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix testworlds PID check and ps edge case found using chroot. #412

merged 1 commit into from
Jan 8, 2024

Conversation

AliceLR
Copy link
Owner

@AliceLR AliceLR commented Jan 8, 2024

  • MZX 2.93 broke getting the process ID from mzxrun in run.sh.
  • Fixed a run.sh edge case that seems to occur only in chroot: mzxrun will not always appear in the process list unless -e is provided.

@AliceLR AliceLR added bug Platform: All (native) All platforms that support building and running mzxrun and/or utils natively. Introduced in 2.93X labels Jan 8, 2024
@AliceLR AliceLR added this to the 2.93b milestone Jan 8, 2024
@AliceLR AliceLR merged commit a57d98a into master Jan 8, 2024
14 checks passed
@AliceLR AliceLR deleted the fix-testworlds-pid branch January 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Introduced in 2.93X Platform: All (native) All platforms that support building and running mzxrun and/or utils natively.
Projects
None yet
Milestone
2.93b
Development

Successfully merging this pull request may close these issues.
1 participant
@AliceLR