Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix board message clipping and color code behavior. #441

Merged
merged 1 commit into from
May 7, 2024

Conversation

AliceLR
Copy link
Owner

@AliceLR AliceLR commented May 7, 2024

  • The board message now clips at the correct position when it overflows the right edge of the board. Previously, it would always be clipped at BYTE 80 instead of after the final byte that would display on screen. This caused wrapping bugs with non-centered message columns >0 and would clip messages containing color codes too early.
  • When the board message clips the right side of the screen, the next line displayed will now use the correct color code from the previous line (as if no clipping had occurred) instead of whatever the last color that displayed on the screen was.
  • Fixed some minor errors in color_string_length and color_string_index_of. They should now behave identically to the old strlencolor with regards to color codes and escapes. They also now take const string pointers.

@AliceLR AliceLR added this to the 2.93b milestone May 7, 2024
@AliceLR AliceLR merged commit 7b197c5 into master May 7, 2024
18 checks passed
@AliceLR AliceLR deleted the fix-message-clipping branch May 7, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant