Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: cleanup HistogramRegistry::fill function #12835

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

ktf
Copy link
Member

@ktf ktf commented Mar 8, 2024

DPL: cleanup HistogramRegistry::fill function

  • make sure that the fill method fills arithmetic types.
  • instanciate templates for common case

Stack created with Sapling. Best reviewed with ReviewStack.

@ktf ktf requested a review from a team as a code owner March 8, 2024 09:22
Copy link
Contributor

github-actions bot commented Mar 8, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@alibuild
Copy link
Collaborator

alibuild commented Mar 8, 2024

Error while checking build/O2/fullCI for b98dafc at 2024-03-08 13:10:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:420:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, double)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:421:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, float)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:422:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, int)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:420:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, double)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:421:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, float)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:422:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, int)' does not match any template declaration
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 8, 2024

Error while checking build/O2/fullCI for 870e069 at 2024-03-12 06:34:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:420:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, double)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:421:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, float)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:422:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, int)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:420:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, double)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:421:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, float)' does not match any template declaration
/sw/SOURCES/O2/12835-slc8_x86-64/0/Framework/Core/include/Framework/HistogramRegistry.h:422:22: error: template-id 'fill<>' for 'void o2::framework::HistogramRegistry::fill(const HistName&, int)' does not match any template declaration
ninja: build stopped: subcommand failed.

Full log here.

@ktf ktf changed the title DPL: forward declaration of fill functions DPL: cleanup HistogramRegistry::fill function Mar 12, 2024
* make sure that the fill method fills arithmetic types.
* instanciate templates for common case
@AliceO2Group AliceO2Group deleted a comment from alibuild Mar 13, 2024
@ktf ktf merged commit bb1f858 into AliceO2Group:dev Mar 13, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants