Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIT: add RecPoint reader and writer workflows for FV0 and FDD #13482

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

andreasmolander
Copy link
Collaborator

The main purpose of the commit:

  • Adding workflows for reading RecPoints for FV0 and FDD, these are needed for MC aQC

Secondary purposes that arose during development:

  • ROOT macro for comparing two RecPoint files
  • Workflows for writing RecPoints added for FT0, FV0 and FDD (i.e. simply standalone RecPoint writers, not related to reconstrucion)
  • The two items above were needed to verify the new RecPoint reader workflows, namely by: reconstructing CTFs -> writing RecPoints to file -> Reading RecPoints from file -> Writing RecPoints to new file -> Comparing the two files
  • Minor cosmetics (e.g. reordering of includes) and utility functions (print and == operator functions)

Copy link
Contributor

github-actions bot commented Sep 4, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@andreasmolander
Copy link
Collaborator Author

+async-label async-2024-pbpb-apass4, async-2024-pp-apass7, async-2023-pbpb-apass3, async-2023-pp-apass4

@github-actions github-actions bot added async-2023-pbpb-apass3 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Hi @andreasmolander, the following label names could not be recognised: async-2024-pbpb-apass4, async-2024-pp-apass7

@andreasmolander
Copy link
Collaborator Author

+async-label async-2024-pp-apass1, async-2022-pp-apass7, async-2023-pp-apass4

@github-actions github-actions bot added async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 labels Sep 4, 2024
@andreasmolander
Copy link
Collaborator Author

+async-label async-2023-pbpb-apass4

@github-actions github-actions bot added the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Sep 4, 2024
andreasmolander added a commit to andreasmolander/O2DPG that referenced this pull request Sep 5, 2024
Enable MC aQC for FV0 and FDD. NOTE!!! This needs AliceO2Group/AliceO2#13482 to work!
andreasmolander added a commit to andreasmolander/O2DPG that referenced this pull request Sep 5, 2024
Enable MC aQC for FV0 and FDD. NOTE!!! This needs AliceO2Group/AliceO2#13482 to work!
@alibuild
Copy link
Collaborator

alibuild commented Sep 6, 2024

Error while checking build/O2/fullCI for 768f585 at 2024-09-07 18:07:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1149:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTrackingWorkflow/src/TOFMatchChecker.cxx:108:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Sep 10, 2024

Error while checking build/O2/fullCI for 692e0f2 at 2024-09-15 11:02:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTrackingWorkflow/src/TOFMatchChecker.cxx:108:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1150:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

The main purpose of the commit:
- Adding workflows for reading RecPoints for FV0 and FDD, these are needed for MC aQC

Secondary purposes that arose during development:
- ROOT macro for comparing two RecPoint files
- Workflows for writing RecPoints added for FT0, FV0 and FDD (i.e. simply standalone RecPoint writers, not related to reconstrucion)
- The two items above were needed to verify the new RecPoint reader workflows, namely by: reconstructing CTFs -> writing RecPoints to file -> Reading RecPoints from file -> Writing RecPoints to new file -> Comparing the two files
- Minor cosmetics (e.g. reordering of includes) and utility functions (print and == operator functions)
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 6b9b7a6 at 2024-09-20 22:26:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1
Development

Successfully merging this pull request may close these issues.

4 participants