Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPC-QC] Add DCAr selection to Tracks.cxx #13565

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

makor
Copy link
Contributor

@makor makor commented Oct 4, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@alibuild
Copy link
Collaborator

alibuild commented Oct 4, 2024

Error while checking build/O2/fullCI for c431d33 at 2024-10-10 09:11:

## sw/BUILD/QualityControl-latest/log
/sw/SOURCES/QualityControl/v1.161.0/v1.161.0/Modules/TPC/src/Tracks.cxx:48:25: error: call of overloaded 'setTrackCuts(const float&, const int&, const float&, const float&, const float&, const bool&)' is ambiguous
ninja: build stopped: cannot make progress due to previous errors.

Full log here.

Comment on lines 251 to 253
if (dcaValue > mCutMaxAbsDCAr) {
return true;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

Suggested change
if (dcaValue > mCutMaxAbsDCAr) {
return true;
}
if (mUseCutMaxAbsDCArOnHistos && (dcaValue > mCutMaxAbsDCAr)) {
return true;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, the dcaValue is signed, so one should check std::abs(dcaValue)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is totally true, I will push an update and fix this. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants