-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPC-QC] Add DCAr selection to Tracks.cxx #13565
base: dev
Are you sure you want to change the base?
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Error while checking build/O2/fullCI for c431d33 at 2024-10-10 09:11:
Full log here. |
Detectors/TPC/qc/src/Tracks.cxx
Outdated
if (dcaValue > mCutMaxAbsDCAr) { | ||
return true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
if (dcaValue > mCutMaxAbsDCAr) { | |
return true; | |
} | |
if (mUseCutMaxAbsDCArOnHistos && (dcaValue > mCutMaxAbsDCAr)) { | |
return true; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, the dcaValue is signed, so one should check std::abs(dcaValue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is totally true, I will push an update and fix this. Thanks a lot!
No description provided.