Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implemented flag for .root kinematics input #13571

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[WIP] Implemented flag for .root kinematics input #13571

wants to merge 1 commit into from
+44 −0

Conversation

jackal1-66
Copy link
Collaborator

This PR is related to the ticket https://its.cern.ch/jira/browse/O2-5216
It has been tested locally and the feature works as expected.
Check the ticket for more information.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@jackal1-66 jackal1-66 mentioned this pull request Oct 7, 2024
Open
@jackal1-66
Copy link
Collaborator Author

This PR is strictly connected to AliceO2Group/O2DPG#1760

sawenzel
sawenzel reviewed Oct 10, 2024
View reviewed changes
run/o2sim_parallel.cxx
@@ -512,6 +512,46 @@ int main(int argc, char* argv[])
}
return r;
}
// check if Kinematics input file is provided
LOG(info) << "Kinematics input file: " << conf.getKineInput();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a generator called GeneratorFromO2Kine. This may already be doing most of the work... but we can extend it do be able to directly reading from Alien, applying some timeframe offsetting, and performing additional random modification (such as rotations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawenzel sawenzel sawenzel left review comments

@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel benedikt-voelkel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackal1-66 @sawenzel