Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new FairLogger severity (critical) to DPL and DebugGUI #13957

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

ehellbar
Copy link
Collaborator

requires bump of FairLogger and InfoLogger in alidist first: alisw/alidist#5763

@ehellbar ehellbar requested a review from a team as a code owner February 11, 2025 14:52
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 1876c99 at 2025-02-11 17:14:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/13957-slc9_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 1876c99 at 2025-02-11 19:22:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13957-slc8_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

ktf
ktf previously approved these changes Feb 12, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 2eabb7f at 2025-02-12 17:10:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/13957-slc9_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 2eabb7f at 2025-02-12 19:02:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13957-slc8_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

@ktf
Copy link
Member

ktf commented Feb 13, 2025

Fine with me in general. I think you missed some "::critical" somewhere.

@ehellbar
Copy link
Collaborator Author

ehellbar commented Feb 13, 2025

I fixed the formatting, the remaining issues require the new FairLogger in alidist

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 50dc348 at 2025-02-13 09:11:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/13957-slc9_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 50dc348 at 2025-02-13 09:11:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13957-slc8_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

@ehellbar ehellbar requested a review from davidrohr as a code owner February 20, 2025 07:50
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for a929033 at 2025-02-20 09:17:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/13957-slc9_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for a929033 at 2025-02-20 09:50:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13957-slc8_x86-64/0/Framework/Core/src/runDataProcessing.cxx:3165:56: error: 'critical' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants