Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1427] Store trigger configuration per runs #1848

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Display trigger configuration in a dedicated tab in run details page

Notable changes for developers:

  • Added c++ API to update runs raw trigger configuration

Changes made to the database:

  • Added column to store raw trigger configuration to runs table

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.02%. Comparing base (c164336) to head (8828822).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...b/public/views/Runs/Details/runDetailsComponent.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   44.05%   44.02%   -0.04%     
==========================================
  Files         893      893              
  Lines       15974    15976       +2     
  Branches     3014     3014              
==========================================
- Hits         7038     7034       -4     
- Misses       8936     8942       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the name convention for the data that is to be stored, PR LGTM.

cxx-client/include/BookkeepingApi/RunServiceClient.h Outdated Show resolved Hide resolved
@martinboulais martinboulais force-pushed the mboulais/O2B-1427/store-trigger-configuration branch from e867909 to 1ceab23 Compare February 11, 2025 08:52
@martinboulais martinboulais merged commit 8ef633f into main Feb 12, 2025
21 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1427/store-trigger-configuration branch February 12, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants