Skip to content

Commit

Permalink
OCTRL-759 [core] clearer deployment failure logs for OPS
Browse files Browse the repository at this point in the history
- shortened one phrase and demoted the log to support, as a similar log is always produced for OPS anyway
- removed redundant prefix "deployment error", which IMHO does not add anything to error message which follows (e.g "deployment error error=workflow deployment failed..." becomes "workflow deployment failed...")
  • Loading branch information
knopers8 authored and justonedev1 committed Dec 13, 2024
1 parent eea9149 commit 6a2250b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions core/environment/transition_deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,9 @@ func (t DeployTransition) do(env *Environment) (err error) {
}

if err != nil {
log.WithError(err).
log.WithField("level", infologger.IL_Ops).
WithField("partition", env.Id().String()).
Error("deployment error")
Error(err)
return
}

Expand Down
3 changes: 2 additions & 1 deletion core/task/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,8 @@ func (m *Manager) handleMessage(tm *TaskmanMessage) error {
if err != nil {
log.WithError(err).
WithField("partition", tm.GetEnvironmentId().String()).
Errorf("Failed task creation and Mesos resources allocation during the deployment of the environment. For more details check Devel logs in Info Logger.")
WithField("level", infologger.IL_Support).
Errorf("failed task creation and Mesos resources allocation during the deployment of the environment. More details in Devel logs.")
}
}()
case taskop.ConfigureTasks:
Expand Down

0 comments on commit 6a2250b

Please sign in to comment.