[core] protect from accessing nil t.Task

AliceO2Group · Dec 13, 2024 · c0c2f83 · c0c2f83
1 parent 7195c29
commit c0c2f83
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/core/workflow/taskrole.go b/core/workflow/taskrole.go
@@ -257,14 +257,18 @@ func (t *taskRole) updateState(s sm.State) {
 			EnvironmentId: t.GetEnvironmentId().String(),
 		})
 		if t.state.get() == sm.ERROR {
+			host := ""
+			if t.Task != nil {
+				host = t.Task.GetHostname()
+			}
 			if t.Critical {
 				log.WithField("partition", t.GetEnvironmentId().String()).
 					WithField("level", infologger.IL_Ops).
-					Errorf("critical task '%s' on host '%s' went into ERROR, the environment will stop or tear down", t.Name, t.Task.GetHostname())
+					Errorf("critical task '%s' on host '%s' went into ERROR, the environment will stop or tear down", t.Name, host)
 			} else {
 				log.WithField("partition", t.GetEnvironmentId().String()).
 					WithField("level", infologger.IL_Ops).
-					Errorf("non-critical task '%s' on host '%s' went into ERROR, but the environment might continue", t.Name, t.Task.GetHostname())
+					Errorf("non-critical task '%s' on host '%s' went into ERROR, but the environment might continue", t.Name, host)
 			}
 
 		}