Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCTRL-802][core] no fill info if the last fill had no stable beams #496

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[OCTRL-802][core] no fill info if the last fill had no stable beams #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/integration/bookkeeping/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,8 @@ func (p *Plugin) CallStack(data interface{}) (stack map[string]interface{}) {
Error("bookkeeping plugin RetrieveFillInfo error")
call.VarStack["__call_error_reason"] = err.Error()
call.VarStack["__call_error"] = callFailedStr
} else if lhcFill.StableBeamEnd == nil || *lhcFill.StableBeamEnd != 0 {
} else if (lhcFill.StableBeamStart != nil && *lhcFill.StableBeamStart != 0) && (lhcFill.StableBeamEnd == nil || *lhcFill.StableBeamEnd == 0) {
// we enter here only if stable beams started and are not over (stable beams start exists && stable beams end does not exist)
log.WithField("partition", envId).
WithField("level", infologger.IL_Devel).
WithField("endpoint", viper.GetString("bookkeepingBaseUri")).
Expand All @@ -1438,7 +1439,7 @@ func (p *Plugin) CallStack(data interface{}) (stack map[string]interface{}) {
WithField("level", infologger.IL_Devel).
WithField("endpoint", viper.GetString("bookkeepingBaseUri")).
WithField("call", "RetrieveFillInfo").
Debug("received a reply about fill info, but the stable beam end is in the past, will not read the fill info and will delete any existing")
Debug("received a reply about fill info, but the latest fill is over or stable beams are not started yet, will not read the fill info and will delete any existing")
deleteLHCInfoInVarStack(varStack)
}
return
Expand Down
Loading