[apricot] implementation of GetRuntimeEntries rpc call #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo
requested changes
Feb 9, 2024
justonedev1
force-pushed
the
OCTRL-548
branch
2 times, most recently
from
4e26b12 to
8e02efa
Compare
teo
requested changes
Feb 13, 2024
teo
requested changes
Feb 15, 2024
apricot/local/service.go
Outdated
| entries := make(map[string]string) | ||
| for _, key := range keys { | ||
| if entry, err := s.GetRuntimeEntry(component, key); err == nil { | ||
| entries[key] = entry | ||
| } else { | ||
| keysErrors = multierror.Append(keysErrors) |
There was a problem hiding this comment.
You're not appending anything into your keysErrors here, otherwise the idea is right.
justonedev1
force-pushed
the
OCTRL-548
branch
from
41df59d to
c2320f2
Compare
teo
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.