Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Ensure auto-transitioning environments always end #525

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[core] Ensure auto-transitioning environments always end #525

merged 1 commit into from
Mar 8, 2024

Conversation

teo
Copy link
Member

@teo teo commented Mar 6, 2024

No description provided.

@teo teo requested review from knopers8 and justonedev1 March 6, 2024 15:06
@justonedev1
Copy link
Collaborator

justonedev1 commented Mar 7, 2024 •
edited
Loading

I would probably name the function differently then goErrorKillDestroy (something like sendErrorAndCleanup), but the code seems ok for me :)

@teo teo merged commit c24398f into master Mar 8, 2024
2 checks passed
@teo teo deleted the OCTRL-858 branch March 8, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justonedev1 justonedev1 justonedev1 approved these changes

@knopers8 knopers8 Awaiting requested review from knopers8

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teo @justonedev1