[core] Improve handling of Mesos resource offers #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue with timing between a Mesos REVIVE call and its corresponding OFFERS event. Specifically: * The channel that pipes incoming deployment requests into the OFFERS handler is now buffered. * We retry an unsatisfiable task deployment 3 times before giving up. * The deployment request is now passed as a pointer. * The response from the OFFERS handler to task.Manager.acquireTasks now goes through its own channel, one per request. * The deployment request is now enqueued immediately *before* a REVIVE, as opposed to after, in order to prevent a race with Mesos.
knopers8
approved these changes
Jun 28, 2024
Comment on lines
+538
to
+540
| // ↑ Not all roles could be deployed. If some were critical, | ||
| // we cannot proceed with running this environment. Either way, | ||
| // we keep the roles running since they might be useful in the future. |
There was a problem hiding this comment.
I don't understand. Where is the part of code which tries to re-deploy only the undeployed tasks?
There was a problem hiding this comment.
I guess the comment is misleading. They would be useful in the future if task reuse was enabled, but it was disabled some years ago since start-stop-start wasn't there yet. In case of partial deployment we'd actually fail, but to my knowledge the current undeployable cases we have are actually early failures where no tasks are deployed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCTRL-777
This commit addresses an issue with timing between a Mesos REVIVE call and its corresponding OFFERS event.
Specifically: