[core] Ensure TRG timeouts are obeyed + add polling timeout #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
reviewed
Oct 23, 2024
| timeout := callable.AcquireTimeout(TRG_START_TIMEOUT, varStack, "RunStart", envId) | ||
| ctx, cancel := context.WithTimeout(context.Background(), timeout) | ||
| defer cancel() | ||
|
|
There was a problem hiding this comment.
why are you creating the context with timeout here and not next to the place where it is needed? (line 889)
There was a problem hiding this comment.
I just did it in the same spot as in ddsched. Shouldn't change much either way, as between here and the call we only have declarations and a Kafka event.
This is my concern too, breaking existing behaviour, but I've been told the timeouts already set in readout-dataflow (which I also used as defaults, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.