moved logs connected to unknown undeployable to Devel #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we move those to DEVEL, are we left with some high-level error for an operator? |
teo
previously approved these changes
Oct 29, 2024
justonedev1
force-pushed
the
error_moving
branch
from
f03e42c to
480a31b
Compare
|
I added more logs to Devel, and one general error that shift crew is going to see only when whole retry mechanism fails. |
teo
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I talked with Vasco and it is possible to release and deploy before HI if we do just log changes. So I went over logs from OCTRL-777 logs and moved these to Devel level so crew will not get overwhelmed when this error (which is covered by retry) is triggered.
For the record: this PR is not meant to be as a whole solution for OCTRL-945, I am still working on more concise logging.