Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Adding http metrics endpoint #641

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[core] Adding http metrics endpoint #641

merged 2 commits into from
Dec 12, 2024

Conversation

justonedev1
Copy link
Collaborator

@justonedev1 justonedev1 commented Dec 9, 2024

This PR is adding http endpoint to be scraped by other tools (eg. Telegraf). Apart from mechanism to create metrics endpoint I also added mechanism to publish golang internal metrics.

P.S.: I changed this to a draft, so we can discuss it before merging.

@justonedev1 justonedev1 requested a review from knopers8 December 9, 2024 16:57
@justonedev1 justonedev1 marked this pull request as draft December 9, 2024 17:03
@justonedev1 justonedev1 marked this pull request as ready for review December 11, 2024 15:57
@justonedev1 justonedev1 requested a review from teo December 12, 2024 10:06
teo
teo previously approved these changes Dec 12, 2024
common/ecsmetrics/metrics.go Outdated Show resolved Hide resolved
core/core.go Outdated
defer ecsmetrics.StopGolangMetrics()
defer monitoring.Stop()

log.Infof("Everything initiated Listening on control port: %d", viper.GetInt("controlPort"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think operators care about which ports are being listened on. imho, you could consider setting it to info/support.

knopers8
knopers8 previously approved these changes Dec 12, 2024
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@knopers8 knopers8 merged commit d6a022e into master Dec 12, 2024
2 checks passed
@knopers8 knopers8 deleted the OCTRL-346 branch December 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants