Cleanups in local.Service interface and better test coverage #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns methods offered by Service to return []string instead of JSON string or space-separated values in a string, making it easier to handle internally. Translation to any particular format, be it JSON, is performed by the API code.
knopers8
force-pushed
the
tests-service
branch
from
257eece to
8500b45
Compare
knopers8
force-pushed
the
tests-service
branch
from
8500b45 to
5edcea4
Compare
teo
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preparatory work for OCTRL-980, which includes:
local.Serviceinterface to use consistently go structures for returning many elements, so it's easier to use internally. API is preserved as it was.local(apricot) andtemplatepackages, to cover the changes above, but not only.