Skip to content

[core] Counting number of status updates in transition_deploy #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justonedev1
Copy link
Collaborator

@justonedev1 justonedev1 commented Apr 1, 2025

@knopers8 Do you think, that this can work for making environment deployment fail faster? I am not sure whether number of leafs gathered from LeafWalk can be comparable to the total amount status updates that we are receiving.

I tested that only on my openstack with 5 tasks. But if you think that it is worth investigating, I can take a look at staging

@justonedev1 justonedev1 requested a review from knopers8 April 1, 2025 13:00
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid we are relying here on a quite far-fetched assumption that there is always just one status update per leaf. Even if this is correct now, we risk breaking this optimization if something changes about it in the future.

I would rather investigate if we could have a stupid channel listening for any deployment failure of a critical task and abort accordingly this loop in case that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants